[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a3603ff99ff: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

MaskRay added a comment. In D136660#3881647 , @mgorny wrote: > In D136660#3881617 , @MaskRay wrote: > >> In D136660#3881602 , @mgorny wrote: >> >>> I suppose you want to

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

mgorny added a comment. In D136660#3881617 , @MaskRay wrote: > In D136660#3881602 , @mgorny wrote: > >> I suppose you want to remove it from `clang/CMakeLists.txt` as well. I see >> Flang has copied the same

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

MaskRay added a comment. Since the patch subject is called `[clang] ` I am deferring the flang cmake change to a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136660/new/ https://reviews.llvm.org/D136660

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

MaskRay updated this revision to Diff 470383. MaskRay edited the summary of this revision. MaskRay added a comment. Remove cmake variable BACKEND_PACKAGE_STRING Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136660/new/

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

MaskRay added a comment. In D136660#3881602 , @mgorny wrote: > I suppose you want to remove it from `clang/CMakeLists.txt` as well. I see > Flang has copied the same logic too, so might be worthwhile to remove it > there as well.

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

mgorny added a comment. I suppose you want to remove it from `clang/CMakeLists.txt` as well. I see Flang has copied the same logic too, so might be worthwhile to remove it there as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136660/new/

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. This seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136660/new/ https://reviews.llvm.org/D136660

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

MaskRay created this revision. MaskRay added reviewers: mgorny, thieta, tstellar. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.