[PATCH] D13673: Add initial support for the MUSL C library.

ldionne added a comment. In D13673#2394187 , @jroelofs wrote: > More context: https://www.openwall.com/lists/musl/2013/03/29/13 Thanks for the context. This is a very puristic point of view from the musl author.. not very useful. There are things that

[PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added a comment. More context: https://www.openwall.com/lists/musl/2013/03/29/13 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13673/new/ https://reviews.llvm.org/D13673 ___ cfe-commits mailing list

[PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added a comment. In D13673#2394064 , @ldionne wrote: > @vkalintiris @jroelofs Is it possible to detect Musl through some macro? I'd > like to get rid of the CMake option -- this isn't the sort of property that > we want to set explicitly at

[PATCH] D13673: Add initial support for the MUSL C library.

ldionne added a comment. Herald added subscribers: krytarowski, mgorny. @vkalintiris @jroelofs Is it possible to detect Musl through some macro? I'd like to get rid of the CMake option -- this isn't the sort of property that we want to set explicitly at configure time, it's the sort of property

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF added a comment. Yep. That's a flaky test. No need to worry. Repository: rL LLVM http://reviews.llvm.org/D13673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13673: Add initial support for the MUSL C library.

This revision was automatically updated to reflect the committed changes. Closed by commit rL252457: Add initial support for the MUSL C library. (authored by vkalintiris). Changed prior to commit: http://reviews.llvm.org/D13673?vs=38788=39673#toc Repository: rL LLVM

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris added a comment. Thanks for the review! Everything seems fine from the buildbots except for a single test that failed: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-debian/builds/730 The next build (731) of that buildbot was green. Is

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D13673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris updated this revision to Diff 38788. vkalintiris added a comment. s/__NetBSD_\)/__NetBSD__\)/ http://reviews.llvm.org/D13673 Files: CMakeLists.txt include/__config include/__config_site.in include/__locale include/support/musl/xlocale.h src/locale.cpp Index:

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris added a comment. In http://reviews.llvm.org/D13673#271518, @EricWF wrote: > Thanks for the update, I think this should be good to go. I'll give it a > final once over tonight. Ping. http://reviews.llvm.org/D13673 ___ cfe-commits

RE: [PATCH] D13673: Add initial support for the MUSL C library.

...@google.com; danalb...@google.com; srhi...@google.com; cfe-commits@lists.llvm.org Subject: Re: [PATCH] D13673: Add initial support for the MUSL C library. vkalintiris added a comment. In http://reviews.llvm.org/D13673#271518, @EricWF wrote: > Thanks for the update, I think this should be g

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris updated this revision to Diff 37850. vkalintiris marked 6 inline comments as done. vkalintiris added a comment. Sorry for the delay. Addressed reviewer comments and modifed CMake to check that LIBCXX_INSTALL_SUPPORT_HEADERS is not turned off when LIBCXX_LIBC_IS_MUSL is ON.

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris added inline comments. Comment at: src/locale.cpp:958 @@ -957,3 +961,3 @@ return static_cast(__classic_lower_table()[static_cast(c)]); -#elif defined(__GLIBC__) || defined(__EMSCRIPTEN__) || defined(__NetBSD__) return isascii(c) ? EricWF

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF added a comment. Thanks for the update, I think this should be good to go. I'll give it a final once over tonight. Comment at: src/locale.cpp:958 @@ -957,3 +961,3 @@ return static_cast(__classic_lower_table()[static_cast(c)]); -#elif defined(__GLIBC__) ||

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris updated this revision to Diff 37335. vkalintiris added a comment. Address reviewers' comments. http://reviews.llvm.org/D13673 Files: CMakeLists.txt include/__config include/__config_site.in include/__locale include/support/musl/xlocale.h src/locale.cpp Index:

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris added inline comments. Comment at: CMakeLists.txt:309 @@ -307,1 +308,3 @@ +config_define_if(LIBCXX_LIBC_IS_MUSL _LIBCXX_LIBC_IS_MUSL) + EricWF wrote: > Please name the macro "_LIBCPP_HAS_MUSL_LIBC" for consistency. Should I rename the corresponding

Re: [PATCH] D13673: Add initial support for the MUSL C library.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. http://reviews.llvm.org/D13407 has landed. http://reviews.llvm.org/D13673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. I don't think this is ready to go. Please don't commit yet. Sorry @jroelofs. Comment at: CMakeLists.txt:309 @@ -307,1 +308,3 @@

Re: [PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added inline comments. Comment at: include/__config:370 @@ -369,2 +369,3 @@ #elif defined(__linux__) -#include +#if defined(__GLIBC__) +# include EricWF wrote: > Where does the `__GLIBC__` macro definition come from? I thought it came > from the C

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF added inline comments. Comment at: include/__config:370 @@ -369,2 +369,3 @@ #elif defined(__linux__) -#include +#if defined(__GLIBC__) +# include jroelofs wrote: > EricWF wrote: > > Where does the `__GLIBC__` macro definition come from? I thought it

[PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris created this revision. vkalintiris added reviewers: mclow.lists, jroelofs, EricWF. vkalintiris added a subscriber: cfe-commits. vkalintiris added a dependency: D13407: [libcxx] Capture configuration information when installing the libc++ headers. Herald added subscribers: srhines,

Re: [PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added a comment. LGTM, with one small nit (and once http://reviews.llvm.org/D13407 lands): Comment at: src/locale.cpp:1176 @@ -1171,3 +1175,3 @@ } -#endif // __GLIBC__ || __EMSCRIPTEN__ || __NETBSD__ +#endif // __GLIBC__ || __NETBSD__ || || __EMSCRIPTEN__ ||