[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

aqjune abandoned this revision. aqjune added a comment. Closing this as D142388 added a function that can be used instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136737/new/ https://reviews.llvm.org/D136737

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11725 +TreeTransform::TransformUnspecifiedValueExpr(UnspecifiedValueExpr *E) { + return E; +} aaron.ballman wrote: > @erichkeane -- is this correct, or does work need to be done to ins

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

aaron.ballman added a comment. It looks like this is missing parsing logic and test cases. Comment at: clang/include/clang-c/Index.h:1534-1539 + /** + * A clang-builtin of unspecified value. + */ + CXCursor_UnspecifiedValueExpr = 155, + + CXCursor_LastExpr = CXCursor_Uns

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

erichkeane added a subscriber: aaron.ballman. erichkeane added a comment. Also, as discussed with @aaron.ballman, 'unspecified' has VERY specific meaning in C/C++, and you don't seem to mean that here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

erichkeane added a comment. It doesn't really make sense to me why this is an AST node expr-node-type rather than just being a call to a builtin (that'll likely need to take a var as a parameter)? We can make that builtin result in a freeze/poison value if necessary. So something like: `_si

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

aqjune added a comment. The updates are analogous to how `GNUNullExprClass` is processed because `UnspecifiedValueExprClass` and it is similar (have no operand). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136737/new/ https://reviews.llvm.org/D1

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

aqjune created this revision. Herald added subscribers: steakhal, martong, arphaman. Herald added a reviewer: shafik. Herald added a reviewer: NoQ. Herald added a project: All. aqjune requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This pat