This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5d086cce8b92: [Clang] perform "maximum TLS
alignment" check for template instantiation (authored by ychen).
Repository:
rG LLVM Github Monorepo
C
ychen added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:14038-14039
+
+ if (!Context.getTargetInfo().isTLSSupported())
+return;
+
mizvekov wrote:
> Is this needed? It seems `getMaxTLSAlign()` will return 0 in that case anyway.
It is checked in t
ychen updated this revision to Diff 470858.
ychen added a comment.
Herald added a reviewer: aaron.ballman.
- remove unnecessary check
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136744/new/
https://reviews.llvm.org/D136744
Files:
clang/include
mizvekov accepted this revision.
mizvekov added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Sema/SemaDecl.cpp:14038-14039
+
+ if (!Context.getTargetInfo().isTLSSupported())
+return;
+
Is this needed? It seems `getM
ychen created this revision.
ychen added reviewers: probinson, mizvekov.
Herald added a project: All.
ychen requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
follow up d30e2eefc3cf8dfd2210aefd62f13a6e7c011b43
Repository:
rG LLVM Github Mo
