[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG117d792f35e6: [clang-format] Don't skip #else/#elif of #if 0 (authored by owenpan). Changed prior to commit: https://reviews.llvm.org/D137052?vs=4

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

owenpan added a comment. In D137052#3899091 , @aaron.ballman wrote: > Can you also add a test for `#elifdef` and `#elifndef`? I added a test (lines 6130-6136) for `#elif` but not `#elifdef` and `#elifndef` because all three are on the same execution pa

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

MyDeveloperDay added subscribers: curdeius, djasper, klimek. MyDeveloperDay added a comment. In D137052#3899094 , @sstwcw wrote: > It just occurred to me that klimek is the one who added all this stuff. Why > didn't you include him as a reviewer? @djas

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

sstwcw added a comment. It just occurred to me that klimek is the one who added all this stuff. Why didn't you include him as a reviewer? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137052/new/ https://reviews.llvm.org/D137052 ___ cfe-com

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

aaron.ballman added a comment. Can you also add a test for `#elifdef` and `#elifndef`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137052/new/ https://reviews.llvm.org/D137052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

sstwcw accepted this revision. sstwcw added a comment. This revision is now accepted and ready to land. Thanks for fixing the problem I caused. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137052/new/ https://reviews.llvm.org/D137052 ___ cfe

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

owenpan added a comment. In D137052#3895426 , @sstwcw wrote: > This patch fixes the regression caused by 2183fe2 > while > introducing a new regression. But in my opinion the new reg

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

owenpan updated this revision to Diff 472204. owenpan added a comment. Tweaked the fix and added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137052/new/ https://reviews.llvm.org/D137052 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

sstwcw added a comment. This patch fixes the regression caused by 2183fe2 while introducing a new regression. But in my opinion the new regression is less of a problem than the old one. Therefore I think it is okay. Take t

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

owenpan created this revision. owenpan added reviewers: sstwcw, sammccall, HazardyKnusperkeks, MyDeveloperDay, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commit