[PATCH] D137309: [clang] Added Swift support for RISCV

craig.topper added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10555 namespace { -class RISCVABIInfo : public DefaultABIInfo { +class RISCVABIInfo : public SwiftABIInfo { private: SwiftABIInfo doesn't inherit from ABIInfo and hasn't since Augu

[PATCH] D137309: [clang] Added Swift support for RISCV

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10557 private: + DefaultABIInfo defaultInfo; // Size of the integer ('x') registers in bits. Huh? This is unused. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10601

[PATCH] D137309: [clang] Added Swift support for RISCV

colemancda added a comment. In D137309#3914550 , @asb wrote: > In D137309#3914494 , @colemancda > wrote: > >> RV32 is enabled as well. I'll add unit tests. > > Great, thanks. Is it really the case that shouldPass

[PATCH] D137309: [clang] Added Swift support for RISCV

asb added a comment. In D137309#3914494 , @colemancda wrote: > RV32 is enabled as well. I'll add unit tests. Great, thanks. Is it really the case that shouldPassIndirectlyForSwift has the same result regardless of native word size? Repository: rG L

[PATCH] D137309: [clang] Added Swift support for RISCV

colemancda added a comment. RV32 is enabled as well. I'll add unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137309/new/ https://reviews.llvm.org/D137309 ___ cfe-commits mailing list cfe-commi