[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:17 + +#include "clang/ASTMatchers/ASTMatchFinder.h" + Ok so this is what caused the revert (https://lab.llvm.org/buildbot#builders/121/builds/25877): ```lines=10

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27ec85f8: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffers. (authored by Artem Dergachev adergac...@apple.com). Herald

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

NoQ added a comment. Ok I added D136811 as a parent revision but I don't think it makes sense to land D136811 before this patch, given that D136811 's documentation does not *yet* reflect

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:34 +// through the handler class. +void checkUnsafeBufferUsage(const Decl *D, UnsafeBufferUsageHandler ); + NoQ

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:50 + M.addMatcher( + stmt(forEachDescendant( +stmt( aaron.ballman wrote: > Errr, this looks expensive to me, but maybe I'm forgetting (I can't recall if > it's

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:29 + /// Invoked when an unsafe operation over raw pointers is found. + virtual void handleUnsafeOperation(const Stmt *Operation) = 0; +}; NoQ wrote: > xazax.hun

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

NoQ updated this revision to Diff 479134. NoQ marked 4 inline comments as done. NoQ added a comment. Add range highlighting, unhardcode language mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137346/new/ https://reviews.llvm.org/D137346 Files:

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:34 +// through the handler class. +void checkUnsafeBufferUsage(const Decl *D, UnsafeBufferUsageHandler ); + aaron.ballman wrote: > Do we need the interface to accept

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

aaron.ballman added subscribers: njames93, sammccall, LegalizeAdulthood, klimek. aaron.ballman added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:34 +// through the handler class. +void checkUnsafeBufferUsage(const Decl *D,

[PATCH] D137346: -Wunsafe-buffer-usage: Initial commit - Transition away from raw buffer accesses.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:29 + /// Invoked when an unsafe operation over raw pointers is found. + virtual void handleUnsafeOperation(const Stmt *Operation) = 0; +}; xazax.hun wrote: > What

[PATCH] D137346: -Wunsafe-buffer-usage: Initial commit - Transition away from raw buffer accesses.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:29 + /// Invoked when an unsafe operation over raw pointers is found. + virtual void handleUnsafeOperation(const Stmt *Operation) = 0; +}; What is the

[PATCH] D137346: -Wunsafe-buffer-usage: Initial commit - Transition away from raw buffer accesses.

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. @aaron.ballman Do you have any objection to us landing this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137346/new/