[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'

probinson added a comment. The clang-ppc64-aix bot ran with these changes here and all results are as expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137437/new/

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64e4d03c681a: [lit][AIX] Convert clang tests to use target={{.*}}-aix{{.*}} (authored by probinson). Changed prior to commit:

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'

probinson added a comment. Lacking an LGTM from someone with AIX knowledge, I see there's a bot "clang-ppc64-aix" where I can verify that the test results haven't changed. For this review the set of tests are mostly UNSUPPORTED, except for three XFAIL. I'll let this sit a little while in case

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'

probinson updated this revision to Diff 478382. probinson retitled this revision from "[lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'" to "[lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'". probinson added a comment. Be consistent about using `-aix` CHANGES

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM w/ normalization. I suggest trying to land these changes sooner rather than later since this is bound to merge conflict and become stale. CHANGES SINCE LAST ACTION

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

probinson added inline comments. Comment at: clang/test/ClangScanDeps/modules-no-undeclared-includes.c:3 // section in XCOFF yet. -// UNSUPPORTED: aix +// UNSUPPORTED: target={{.*}}aix{{.*}} hubert.reinterpretcast wrote: > Perhaps we should normalize on

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

hubert.reinterpretcast added inline comments. Comment at: clang/test/ClangScanDeps/modules-no-undeclared-includes.c:3 // section in XCOFF yet. -// UNSUPPORTED: aix +// UNSUPPORTED: target={{.*}}aix{{.*}} Perhaps we should normalize on `-aix` while we are

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

probinson edited subscribers, added: cfe-commits; removed: clang. probinson added a comment. Try again to add the commits list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137437/new/ https://reviews.llvm.org/D137437 ___ cfe-commits