This revision was automatically updated to reflect the committed changes.
Closed by commit rGcab9c02bd97f: [Clang] Fix behavior of -ffp-model option when
overriden (authored by qiucf).
Changed prior to commit:
https://reviews.llvm.org/D137618?vs=475981&id=476309#toc
Repository:
rG LLVM Githu
qiucf marked an inline comment as done.
qiucf added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137618/new/
https://reviews.llvm.org/D137618
___
cfe-commits mailing list
cfe-commits@
zahiraam added a comment.
Looks good to me after the additional RUN line mentioned in my comment for
Driver/fp-model.c is added. Thanks.
Comment at: clang/test/Driver/fp-model.c:77
+// WARN12-NOT: warning: overriding '-ffp-model=strict' option with
'-ffp-model=strict' [-Wove
qiucf added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3034
RoundingFPMath = false;
+ FPExceptionBehavior = "";
// If fast-math is set then set the fp-contract mode to fast.
zahiraam wrote:
> FPExceptionBehavior should
qiucf updated this revision to Diff 475981.
qiucf marked an inline comment as done.
qiucf added a comment.
Update test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137618/new/
https://reviews.llvm.org/D137618
Files:
clang/lib/Driver/ToolCh
zahiraam added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3034
RoundingFPMath = false;
+ FPExceptionBehavior = "";
// If fast-math is set then set the fp-contract mode to fast.
FPExceptionBehavior should be set here and
qiucf updated this revision to Diff 474142.
qiucf marked an inline comment as done.
qiucf added a reviewer: michele.scandale.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137618/new/
https://reviews.llvm.org/D137618
Files:
clang/lib/Driver/ToolCh
zahiraam added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2844
FPContract = "fast";
+FPExceptionBehavior = "";
} else if (Val.equals("precise")) {
I would expect the same thing should happen with -ffp-model=strict -
qiucf created this revision.
qiucf added reviewers: aaron.ballman, mibintc, andrew.w.kaylor, masoud.ataei,
zahiraam.
Herald added a project: All.
qiucf requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
`-ffp-model=strict -ffp-model=f
