[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 abandoned this revision. usaxena95 added a comment. Second attempt along the lines of the last comment: https://reviews.llvm.org/D138914 PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137712/new/ https://reviews.llvm.org/D137712

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

ilya-biryukov added a comment. We discussed this with Utkarsh offline, he's OOO for some time, so I wanted to leave the summary here. This patch attempts to attack the problem by keeping the information about substitution failure in template arguments of `ConceptSpecializationExpr`. However, it

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

erichkeane added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:103 + bool hasSubstitutionFailureInArgs() const { +return ArgsHasSubstitutionFailure; usaxena95 wrote: > erichkeane wrote: > > Does this really belong here instead of as

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:103 + bool hasSubstitutionFailureInArgs() const { +return ArgsHasSubstitutionFailure; erichkeane wrote: > Does this really belong here instead of as a part of the >

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 updated this revision to Diff 475054. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed commented. Added Release notes. Removed infrastructure changes and deferred them to a future patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

erichkeane added a comment. I think this is a move in the right direction, and generally is probably pretty close. The new bool for `ArgsHasSubstitutionFailure` isn't something I get the need for yet though. we also need release notes. Comment at:

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 updated this revision to Diff 474716. usaxena95 added a comment. Moving closer to show diagnostic of entity for which SFNIAE occurred. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137712/new/ https://reviews.llvm.org/D137712 Files:

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

shafik added inline comments. Comment at: clang/lib/AST/ExprConcepts.cpp:112-113 + return ConceptSpecializationExpr::Create( + C, NNS, TemplateKWLoc, ConceptNameInfo, FoundDecl, NamedConcept, nullptr, + nullptr, Satisfaction); +} I think I got the

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

erichkeane added a comment. I dont have a good hold as to why this is the solution, can you better explain the issue and the solution that you made? I will take a look when I get a chance next week, as the ISO meeting is taking up my week. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137712 Files: