[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

This revision was automatically updated to reflect the committed changes. Closed by commit rGec094d259ecf: [z/OS][pg] Throw error when using -pg on z/OS (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii updated this revision to Diff 495570. francii added a comment. Update test case verbosity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii updated this revision to Diff 495267. francii added a comment. Rebase and test case update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/Driver/zos-profiling-error.c:1 +// Check failed cases + Delete this comment. It does not help reading the test.

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii updated this revision to Diff 493401. francii added a comment. Move check to Clang.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/ZOS.cpp:22 +: ToolChain(D, Triple, Args) { + for (Arg *A : Args.filtered(options::OPT_pg)) { +auto ArgString = A->getAsString(Args); francii wrote: > @MaskRay we still need `-pg` to

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii added inline comments. Comment at: clang/lib/Driver/ToolChains/ZOS.cpp:22 +: ToolChain(D, Triple, Args) { + for (Arg *A : Args.filtered(options::OPT_pg)) { +auto ArgString = A->getAsString(Args); @MaskRay we still need `-pg` to error-out on

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii added a comment. In D137756#4023531 , @hubert.reinterpretcast wrote: > In D137756#4018666 , @MaskRay wrote: > >> Most targets reject `-p` now. It's unnecessary to have another z/OS specific >>

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

hubert.reinterpretcast added a comment. In D137756#4018666 , @MaskRay wrote: > Most targets reject `-p` now. It's unnecessary to have another z/OS specific > diagnostic. So this patch can be abandoned. > > % fclang -p a.cc > clang-16: error:

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Most targets reject `-p` now. It's unnecessary to have another z/OS specific diagnostic. So this patch can be abandoned. % fclang -p a.cc clang-16: error: unsupported option