This revision was automatically updated to reflect the committed changes.
Closed by commit rL252036: [Sema] Implement __make_integer_seq (authored by
majnemer).
Changed prior to commit:
http://reviews.llvm.org/D13786?vs=39153&id=39154#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13786
majnemer updated this revision to Diff 39153.
majnemer added a comment.
- Address Richard's latest comments
http://reviews.llvm.org/D13786
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTVis
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Please add a test for serialization/deserialization of this declaration.
Otherwise, this looks fine.
Comment at: include/clang/Serialization/ASTBitCodes.h:994
@@ -990,3 +993,
majnemer updated this revision to Diff 39145.
majnemer added a comment.
- Add an llvm_unreachable to ASTDeclReader::VisitBuiltinTemplateDecl
- Address Richard's review comments.
- Add logic to check [intseq.intseq]p1.
- Remove TemplateName::BuiltinTemplate
- Rename BuiltinTemplateNameKind to Built
rsmith added inline comments.
Comment at: lib/AST/ASTDumper.cpp:1340-1344
@@ +1339,7 @@
+ dumpName(D);
+ switch (D->getBuiltinTemplateKind()) {
+ case BTK__make_integer_seq:
+OS << " __make_integer_seq";
+break;
+ }
+ dumpTemplateParameters(D->getTemplateParameters())
majnemer added a comment.
Ping.
http://reviews.llvm.org/D13786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer added a comment.
@rsmith, I've kept the caching of the `BuiltinTemplateDecl` for
`__make_integer_seq` as we keep falling into the `LookupBuiltin`. Is there more
that must be done to get "normal" lookups to find the decl?
http://reviews.llvm.org/D13786
__
majnemer updated this revision to Diff 37676.
majnemer added a comment.
- Add test for __make_integer_seq
http://reviews.llvm.org/D13786
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTVisit
majnemer updated this revision to Diff 37675.
majnemer added a comment.
- Make __make_integer_seq parameters as implicit
- Remove Sema::Ident___make_integer_seq
- Remove extraneous whitespace change
http://reviews.llvm.org/D13786
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DataR
majnemer updated this revision to Diff 37674.
majnemer added a comment.
- Rename BuiltinTemplateNameKind to BuiltinTemplateKind
http://reviews.llvm.org/D13786
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/DeclTemplate.h
include/clang
majnemer updated this revision to Diff 37673.
majnemer added a comment.
- Remove TemplateName::BuiltinTemplate
http://reviews.llvm.org/D13786
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveAST
majnemer updated this revision to Diff 37612.
majnemer added a comment.
- Add an llvm_unreachable to ASTDeclReader::VisitBuiltinTemplateDecl
- Address Richard's review comments.
- Add logic to check [intseq.intseq]p1.
http://reviews.llvm.org/D13786
Files:
include/clang/AST/ASTContext.h
incl
majnemer updated this revision to Diff 37558.
majnemer marked 2 inline comments as done.
majnemer added a comment.
- Address Richard's review comments.
http://reviews.llvm.org/D13786
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/DeclTe
EricWF added a subscriber: EricWF.
EricWF added a comment.
Cool! I imagine that a lot of parts of libc++ could benefit from this. Having
something like this that slices parameter packs would probably help libc++
compile times for tuple. Is that something your considering as well?
http://review
rsmith added inline comments.
Comment at: include/clang/AST/TemplateName.h:93-100
@@ +92,10 @@
+
+/// \brief A structure for storing the information associated with an
+/// builtin template name.
+class BuiltinTemplateStorage : public UncommonTemplateNameStorage {
+ friend class
majnemer updated this revision to Diff 37518.
majnemer added a comment.
- Add an llvm_unreachable to ASTDeclReader::VisitBuiltinTemplateDecl
http://reviews.llvm.org/D13786
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/DeclTemplate.h
majnemer created this revision.
majnemer added a reviewer: rsmith.
majnemer added a subscriber: cfe-commits.
This new builtin template allows for incredibly fast instantiations of
templates like std::integer_sequence.
Performance numbers follow:
My work station has 64 GB of ram + 20 Xeon Cores at
17 matches
Mail list logo
