[PATCH] D137885: [modules] Support zstd in .pcm file

MaskRay added a comment. In D137885#3947532 , @dyung wrote: > @MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. > Most of the errors look similar to this: > > error: 'error' diagnostics seen but not expected: > (frontend

[PATCH] D137885: [modules] Support zstd in .pcm file

dyung added a comment. In D137885#3947532 , @dyung wrote: > @MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. > Most of the errors look similar to this: > > error: 'error' diagnostics seen but not expected: > (frontend):

[PATCH] D137885: [modules] Support zstd in .pcm file

dyung added a comment. @MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. Most of the errors look similar to this: error: 'error' diagnostics seen but not expected: (frontend): malformed or corrupted AST file: 'LLVM was not built with LLVM_ENABLE_ZSTD or did not

[PATCH] D137885: [modules] Support zstd in .pcm file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa7bc386ec75: [modules] Support zstd in .pcm file (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D137885: [modules] Support zstd in .pcm file

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137885/new/ https://reviews.llvm.org/D137885

[PATCH] D137885: [modules] Support zstd in .pcm file

MaskRay marked an inline comment as done. MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137885/new/ https://reviews.llvm.org/D137885 ___ cfe-commits mailing list cfe-commi

[PATCH] D137885: [modules] Support zstd in .pcm file

dblaikie added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:1457 + const llvm::compression::Format F = + Blob.size() >= 2 && memcmp(Blob.data(), "\x1f\x8b", 2) == 0 + ? llvm::compression::Format::Zlib MaskRay wrote

[PATCH] D137885: [modules] Support zstd in .pcm file

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:1457 + const llvm::compression::Format F = + Blob.size() >= 2 && memcmp(Blob.data(), "\x1f\x8b", 2) == 0 + ? llvm::compression::Fo

[PATCH] D137885: [modules] Support zstd in .pcm file

dblaikie added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:1457 + const llvm::compression::Format F = + Blob.size() >= 2 && memcmp(Blob.data(), "\x1f\x8b", 2) == 0 + ? llvm::compression::Format::Zlib tschuett wrot

[PATCH] D137885: [modules] Support zstd in .pcm file

tschuett added a comment. Release note? Comment at: clang/lib/Serialization/ASTReader.cpp:1457 + const llvm::compression::Format F = + Blob.size() >= 2 && memcmp(Blob.data(), "\x1f\x8b", 2) == 0 + ? llvm::compression::Format::Zlib Cou

[PATCH] D137885: [modules] Support zstd in .pcm file

MaskRay updated this revision to Diff 476360. MaskRay marked an inline comment as done. MaskRay added a comment. add a comment about the zlib header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137885/new/ https://reviews.llvm.org/D137885 Files:

[PATCH] D137885: [modules] Support zstd in .pcm file

dblaikie added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:1456 + const llvm::compression::Format F = + Blob.size() >= 2 && memcmp(Blob.data(), "\x1f\x8b", 2) == 0 + ? llvm::compression::Format::Zlib Worth a comme

[PATCH] D137885: [modules] Support zstd in .pcm file

MaskRay updated this revision to Diff 474953. MaskRay edited the summary of this revision. MaskRay added a comment. use level 9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137885/new/ https://reviews.llvm.org/D137885 Files: clang/lib/Serializa

[PATCH] D137885: [modules] Support zstd in .pcm file

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, jansvoboda11, rsmith. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend SM_SLOC_BUFFER_B