This revision was automatically updated to reflect the committed changes.
Closed by commit rGc2ec455f183d: [LoongArch] Add intrinsics for ibar, break and
syscall (authored by gonglingqin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138094/new/
ht
SixWeining accepted this revision.
SixWeining added a comment.
This revision is now accepted and ready to land.
LGTM but let's wait for others.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138094/new/
https://reviews.llvm.org/D138094
gonglingqin updated this revision to Diff 475987.
gonglingqin added a comment.
Address @SixWeining's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138094/new/
https://reviews.llvm.org/D138094
Files:
clang/include/clang/Basic/BuiltinsLo
gonglingqin added inline comments.
Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:603
case Intrinsic::loongarch_dbar: {
-SDValue Op0 = Op.getOperand(0);
-SDValue Op2 = Op.getOperand(2);
-if (!isa(Op2)) {
- DAG.getContext()->emitError("argument
SixWeining added inline comments.
Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:603
case Intrinsic::loongarch_dbar: {
-SDValue Op0 = Op.getOperand(0);
-SDValue Op2 = Op.getOperand(2);
-if (!isa(Op2)) {
- DAG.getContext()->emitError("argument
gonglingqin updated this revision to Diff 475715.
gonglingqin added a comment.
Address @arsenm's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138094/new/
https://reviews.llvm.org/D138094
Files:
clang/include/clang/Basic/BuiltinsLoongA
gonglingqin added inline comments.
Comment at: clang/include/clang/Basic/BuiltinsLoongArch.def:20-23
TARGET_BUILTIN(__builtin_loongarch_dbar, "vIUi", "nc", "")
+TARGET_BUILTIN(__builtin_loongarch_ibar, "vIUi", "nc", "")
+TARGET_BUILTIN(__builtin_loongarch_break, "vIUi", "nc", ""
arsenm added inline comments.
Comment at: clang/include/clang/Basic/BuiltinsLoongArch.def:20-23
TARGET_BUILTIN(__builtin_loongarch_dbar, "vIUi", "nc", "")
+TARGET_BUILTIN(__builtin_loongarch_ibar, "vIUi", "nc", "")
+TARGET_BUILTIN(__builtin_loongarch_break, "vIUi", "nc", "")
+TA
gonglingqin created this revision.
gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay,
XiaodongLoong.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
gonglingqin requested review of this revision.
Herald added projects: clang, LLVM.
Herald adde
