[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG0745b0c0354a: Fix incorrect cast in VisitSYCLUniqueStableNameExpr (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138284/new/ https

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138284/new/ https://reviews.llvm.org/D138284 __

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

bader added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1635 + Context.getTargetInfo().getConstantAddressSpace().value_or( + LangAS::Default)); llvm::Constant *GlobalConstStr = Builder.CreateGlobalStringPtr( arichardson wrote:

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

arichardson updated this revision to Diff 476470. arichardson added a comment. Fix to use addrspace(1) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138284/new/ https://reviews.llvm.org/D138284 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/t

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

arichardson added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1635 + Context.getTargetInfo().getConstantAddressSpace().value_or( + LangAS::Default)); llvm::Constant *GlobalConstStr = Builder.CreateGlobalStringPtr( arichardson

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

arichardson added a comment. In D138284#3936846 , @erichkeane wrote: > In D138284#3936830 , @aaron.ballman > wrote: > >> Adding @bader as SYCL code owner. The changes look reasonable to me, but >> codegen is no

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

bader added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1635 + Context.getTargetInfo().getConstantAddressSpace().value_or( + LangAS::Default)); llvm::Constant *GlobalConstStr = Builder.CreateGlobalStringPtr( > This changes the

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

erichkeane added a comment. In D138284#3936830 , @aaron.ballman wrote: > Adding @bader as SYCL code owner. The changes look reasonable to me, but > codegen is not my area of expertise. Yeah, same to me. I wrote this originally, but I think the address

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

aaron.ballman added a reviewer: bader. aaron.ballman added a subscriber: bader. aaron.ballman added a comment. Adding @bader as SYCL code owner. The changes look reasonable to me, but codegen is not my area of expertise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

arichardson created this revision. arichardson added reviewers: erichkeane, rjmccall, aaron.ballman. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Herald added a project: All. arichardson requested review of this revision. Herald added a project: clang. Herald added a subscriber: