[PATCH] D138376: Use None consistently (NFC)

2022-11-20 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138376/new/ https://reviews.llvm.org/D138376 __

[PATCH] D138376: Use None consistently (NFC)

2022-11-20 Thread Alexander Yermolovich via Phabricator via cfe-commits
ayermolo added a comment. Is there an a RFC for this or something? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138376/new/ https://reviews.llvm.org/D138376 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D138376: Use None consistently (NFC)

2022-11-20 Thread Kazu Hirata via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fa870b1bd6c: Use None consistently (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D138376: Use None consistently (NFC)

2022-11-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. `enum class NoneType { None = 1 };` is from 0cd22f9540c0591132ec991c51103cf800cf4e24 (2017) for MSVC workaround. I assume it is no longer needed.. Repository: rG LLVM Github Monore

[PATCH] D138376: Use None consistently (NFC)

2022-11-19 Thread Kazu Hirata via Phabricator via cfe-commits
kazu created this revision. Herald added subscribers: Moerafaat, zero9178, mtrofin, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle