[PATCH] D138387: [Clang] Implement static operator[]

This revision was automatically updated to reflect the committed changes. Closed by commit rG3faf1f17a5c3: [Clang] Implement static operator[] (authored by royjacobson). Changed prior to commit: https://reviews.llvm.org/D138387?vs=477550&id=478493#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D138387: [Clang] Implement static operator[]

erichkeane accepted this revision. erichkeane added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138387/new/ https://reviews.llvm.org/D138387 ___ cfe-commits mailing list cfe-co

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson marked an inline comment as done. royjacobson added a comment. In D138387#3944211 , @cor3ntin wrote: > Beside the formatting nitpick this looks good Thanks! I'll wait until next week to let other people have a chance to take a look. Reposi

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson marked 3 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14462-14467 + RLoc, CurFPFeatureOverrides()); +else + TheCall = + CallExpr::Create(Context, FnExpr.get(), Method

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson updated this revision to Diff 477550. royjacobson added a comment. Add a missing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138387/new/ https://reviews.llvm.org/D138387 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D138387: [Clang] Implement static operator[]

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Beside the formatting nitpick this looks good Comment at: clang/test/CodeGenCXX/cxx2b-static-subscript-operator.cpp:14 + f.operator[](201, 202); + Functor{}[301, 302];

[PATCH] D138387: [Clang] Implement static operator[]

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14462-14467 + RLoc, CurFPFeatureOverrides()); +else + TheCall = + CallExpr::Create(Context, FnExpr.get(), MethodArgs, ResultTy, VK, +

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9111-9115 def ext_operator_overload_static : ExtWarn< "declaring overloaded %0 as 'static' is a C++2b extension">, InGroup, DefaultIgnore; -def err_call_operator_overload_static

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson updated this revision to Diff 476975. royjacobson added a comment. 1. Update warnings according to Corentin's comment 2. Somehow I missed the CodeGen was completely broken. Made a few necessary follow up changes in SemaOverload and ran the tests this time... Repository: rG LLVM Gi

[PATCH] D138387: [Clang] Implement static operator[]

cor3ntin added a comment. Thanks for working on this, it was fast! It looks good except for an issue with the diagnostic (which was partly pre-existing) Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9111-9115 def ext_operator_overload_static : ExtWarn< "decl

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson created this revision. royjacobson added reviewers: cor3ntin, erichkeane. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After accepted in Kona, update the code to accept static operator