[PATCH] D138391: clang/HIP: Add new header test for math IR gen

2022-11-22 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. 2edafe8393fa7c9ad2e95d691191469adb7bf4b0 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138391/new/ https://reviews.llvm.org/D138391

[PATCH] D138391: clang/HIP: Add new header test for math IR gen

2022-11-22 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138391/new/ https://reviews.llvm.org/D138391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138391: clang/HIP: Add new header test for math IR gen

2022-11-22 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Good call adding this test, thanks. I think some of the skipping is glibc quirk related and some was to avoid clobbering the user's namespace for openmp. The math header