[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cddd7a2a1d2: [clang-format][docs] Add ability to link to specific config options (authored by rymiel). Changed prior to commit: https://reviews.llvm.org/D138446?vs=476929&id=488720#toc Repository: r

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

aaron.ballman added a comment. In D138446#4047487 , @MyDeveloperDay wrote: > So if I understand completely its so its easier to pick up an option and > share as a hyperlink i.e. > `<.>/llvm-project/clang/html/ClangFormatStyleOptions.html#allowallc

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. So if I understand completely its so its easier to pick up an option and share as a hyperlink i.e. `<.>/llvm-project/clang/html/ClangFormatStyleOptions.html#allowallconstructorinitializersonnextline` F26159404: image.pn

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

aaron.ballman accepted this revision. aaron.ballman added a comment. In D138446#3942006 , @rymiel wrote: > I consulted a little bit with a friend who has a little bit of experience > with sphinx and they suggested making a simple custom extension for thi

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

rymiel added a comment. Maybe the docs need somewhat of a fresh coat of paint. As a clang-format user it's odd to find the options listed as "ConfigName (`EnumName`)" but when listing the actual options it's "`EnumOption` (In configuration: `ConfigOption`)". At the very least, the order of the l

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

rymiel added a comment. I consulted a little bit with a friend who has a little bit of experience with sphinx and they suggested making a simple custom extension for this. But given that there is no custom sphinx logic right now at all, I don't feel great adding something that novel to the whol

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

HazardyKnusperkeks added a comment. Another point, when looking at that code: All options have the version badge, and any new option should have it too. Maybe the script should just fail if `self.version` is not `true`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Full disclaimer: I have no idea what sphinx really is or how any of this stuff works, I still generate HTML from doxygen. But I think the solution looks nice in code.

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows for the creation of permalinks to specific cl