[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

2023-02-06 Thread Mike Rice via Phabricator via cfe-commits
mikerice added a comment. In D138453#410 , @aaron.ballman wrote: > In D138453#4105211 , @DHowett-MSFT > wrote: > >> >> I believe it's expected that we hit this assertion - it's clearer than the >> origi

[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

2023-02-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D138453#4105211 , @DHowett-MSFT wrote: > In D138453#4105209 , @shafik wrote: > >> It looks like https://github.com/llvm/llvm-project/issues/60543 is hitting >> your added `llvm_

[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

2023-02-05 Thread Dustin L. Howett via Phabricator via cfe-commits
DHowett-MSFT added a comment. In D138453#4105209 , @shafik wrote: > It looks like https://github.com/llvm/llvm-project/issues/60543 is hitting > your added `llvm_unreachable("missing serialization code for annotation > token");` is this expected. I bel

[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

2023-02-05 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. It looks like https://github.com/llvm/llvm-project/issues/60543 is hitting your added `llvm_unreachable("missing serialization code for annotation token");` is this expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

2022-11-29 Thread Mike Rice via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG530eb263c0ec: [clang] Add serialization for loop hint annotation tokens (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://re