[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping. Because Phabricator is set to be made read-only on the 1. of October, it might be better to not review this patch here and instead open it on GitHub instead. Thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti requested review of this revision. 5chmidti added a comment. Never mind, the problem is unrelated to this patch. Filed clangd issue #1710 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/n

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti planned changes to this revision. 5chmidti added a comment. I found a new issue. I'll probably fix it by next weekend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti updated this revision to Diff 538286. 5chmidti added a comment. Ping, and: - change find_if of post-use detection to range-for with a filtered range - make `renderHoistedCall` a private member of `NewFunction` - remove the `Render` lambda in `renderHoistSet` in favor of putting the body

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti updated this revision to Diff 477204. 5chmidti added a comment. Fix windows build by setting the c++ standard for the hoisting tests explicitly to c++17. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti updated this revision to Diff 477184. 5chmidti added a comment. Fixup: rm added includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 Files: clang-tools-extra/clangd/refactor/tweaks/ExtractF

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti created this revision. 5chmidti added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. 5chmidti requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Add