[PATCH] D138505: [clangd] Don't run slow clang-tidy checks by default

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb99f7e695469: [clangd] Don't run slow clang-tidy checks by default

Re: [PATCH] D138505: [clangd] Don't run slow clang-tidy checks by default

Very late, & by email since phab is down. Going to land this based on "LG" comment & offline discussion, happy to do followups if needed. On Mon, Nov 28, 2022 at 10:08 PM Kadir Cetinkaya via Phabricator < revi...@reviews.llvm.org> wrote: > kadircet added a comment. > > thanks LG, i'd like to hea

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks by default

kadircet added a comment. thanks LG, i'd like to hear how we're planning to let downstream users customise the list of fast checks. otherwise they have to run with `Loose` at all times. the easiest i can think of is, generating their own `fastchecks.inc` fragment and #include that in addition t

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks by default

sammccall updated this revision to Diff 478274. sammccall retitled this revision from "[clangd] Don't run slow clang-tidy checks" to "[clangd] Don't run slow clang-tidy checks by default". sammccall edited the summary of this revision. sammccall added a comment. Add tests of isFast Make isFast a

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

sammccall planned changes to this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:518 + +if (F.SlowChecks.has_value()) + Out.Apply.push_back([V = **F.SlowChecks](const Params &, Config &C) { kadircet wrot

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

kadircet added a comment. i can't think of a proper way to test this out either. unless we somehow let slow-tidy-check list to be configurable, so probably fine to make sure it works locally and hope that new people introducing tidy checks do complain. Comment at: clang-tools

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:487 + } + CTFactories = std::move(FastFactories); +} njames93 wrote: > Not exactly related but surely both check factories could be made into static > variables and

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

njames93 added a comment. In D138505#3944285 , @sammccall wrote: > Ideas on testing welcome. Does it make sense to rely on the fact that > `misc-const-correctness` is always slow? :-D I'd say it doesn't, if the check is ever updated in a way to be more

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

sammccall added a comment. Ideas on testing welcome. Does it make sense to rely on the fact that `misc-const-correctness` is always slow? :-D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138505/new/ https://reviews.llvm.org/D138505 _

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a reviewer: njames93. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a proj