[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh abandoned this revision. Pierre-vh added a comment. Added bf16 storage support instead: D139398 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138651/new/ https://reviews.llvm.org/D138651 ___

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh planned changes to this revision. Pierre-vh marked an inline comment as done. Pierre-vh added a comment. I'll take a look at handling bf16 storage-only for AMDGPU. Looks like our Backend already handles it and converts it to i16 so maybe it'll be really easy. Repository: rG LLVM Git

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

tra added inline comments. Comment at: clang/test/SemaCUDA/amdgpu-bf16.cu:9 + +__device__ void devicefn() { +} Pierre-vh wrote: > tra wrote: > > We should probably also have a case verifying that actual attempt to use > > `__bf16` in device code is still diagnos

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh marked an inline comment as done. Pierre-vh added inline comments. Comment at: clang/test/SemaCUDA/amdgpu-bf16.cu:9 + +__device__ void devicefn() { +} tra wrote: > We should probably also have a case verifying that actual attempt to use > `__bf16` in d

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

tra added inline comments. Comment at: clang/test/SemaCUDA/amdgpu-bf16.cu:9 + +__device__ void devicefn() { +} We should probably also have a case verifying that actual attempt to use `__bf16` in device code is still diagnosed. Repository: rG LLVM Github Mo

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh updated this revision to Diff 478823. Pierre-vh marked 5 inline comments as done. Pierre-vh added a comment. - Recentering the patch around HIP only. - I was using too much from D57369 and was involving OpenMP when there's no reason to. Just checking

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

yaxunl added a comment. In D138651#3954179 , @tra wrote: >> Builds were failing because "__bf16" wasn't allowed on the target. > > For CUDA/NVPTX we've solved the issue by implementing storage-only support > for NVPTX: https://reviews.llvm.org/D136311 >

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

tra added a comment. > Builds were failing because "__bf16" wasn't allowed on the target. For CUDA/NVPTX we've solved the issue by implementing storage-only support for NVPTX: https://reviews.llvm.org/D136311 It's a bit more work, but I think it would be a better fix long-term for AMDGPU, too.

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh updated this revision to Diff 477871. Pierre-vh added a comment. Fixing condition, adding new test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138651/new/ https://reviews.llvm.org/D138651 Files: clang/lib/AST/ASTContext.cpp cl

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh updated this revision to Diff 477760. Pierre-vh added a comment. Not all targets have bf16 and AuxTarget may not be available all the time so I changed the condition slightly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138651/new/ http

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh planned changes to this revision. Pierre-vh added a comment. Need to fix a test crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138651/new/ https://reviews.llvm.org/D138651 ___ cfe-commits

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh updated this revision to Diff 477734. Pierre-vh added a comment. Add newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138651/new/ https://reviews.llvm.org/D138651 Files: clang/lib/AST/ASTContext.cpp clang/lib/Sema

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh created this revision. Pierre-vh added reviewers: arsenm, rjmccall, tra. Herald added subscribers: kosarev, mattd, kerbowa, pengfei, tpr, yaxunl, jvesely. Herald added a project: All. Pierre-vh requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Hera