[PATCH] D138677: [Lex] Fix suggested spelling of /usr/bin/../include/foo

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/70650/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138677/new/ https://reviews.llvm.org/D138

[PATCH] D138677: [Lex] Fix suggested spelling of /usr/bin/../include/foo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bed59c7e7da: [Lex] Fix suggested spelling of /usr/bin/../include/foo (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D138677: [Lex] Fix suggested spelling of /usr/bin/../include/foo

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1932 + + llvm::SmallString<32> FilePath(File.begin(), File.end()); + path::remove_dots(FilePath, /*remove_dot_dot=*/true); kadircet wrote:

[PATCH] D138677: [Lex] Fix suggested spelling of /usr/bin/../include/foo

kadircet added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1932 + + llvm::SmallString<32> FilePath(File.begin(), File.end()); + path::remove_dots(FilePath, /*remove_dot_dot=*/true); nit: you can change the method signature to take in a SmallSt

[PATCH] D138677: [Lex] Fix suggested spelling of /usr/bin/../include/foo

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since D60873 we remove dotdots from the search