[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG849b650cf3b6: [clang] Skip defaulted functions in zero-as-null-pointer-constant. (authored by massberg). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg added a comment. Note: The build failures are in parts of the code that isn't effected by this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 ___

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 ___ cfe-commits ma

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg updated this revision to Diff 478477. massberg added a comment. Fixed comments and removed unnecessary includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 Files: clang/lib/Sema/Sema.cpp

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a few NITs. Thanks! Comment at: clang/lib/Sema/Sema.cpp:600 + // Ignore null pointers in defaulted functions, e.g. defaulted comparison + // opera

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg updated this revision to Diff 478261. massberg added a comment. Run clang-format on changed files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 Files: clang/lib/Sema/Sema.cpp clang/test/Se

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg updated this revision to Diff 478227. massberg added a comment. Sync to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 Files: clang/lib/Sema/Sema.cpp clang/test/SemaCXX/warn-zero-nullp

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The zero-as-null-pointer-constant check should not fire if it is inside a defaul