[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat added a comment. In D138810#4571579 , @dyung wrote: > The test you added clang/test/Sema/zvk-invalid.c is failing on bots, for > example https://lab.llvm.org/buildbot/#/builders/139/builds/47055. > > Is the test missing a `REQUIRES: riscv-registe

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

dyung added a comment. The test you added clang/test/Sema/zvk-invalid.c is failing on bots, for example https://lab.llvm.org/buildbot/#/builders/139/builds/47055. Is the test missing a `REQUIRES: riscv-registered-target` line by any chance? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a05a5215f69: [RISCV] Support vector crypto extension C intrinsics (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 ___

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 546746. 4vtomat added a comment. This update does a few things: 1. Update test cases based on rvv-intrinsic-doc. 2. Add checks for "zvknh[a|b]" instructions. 3. Rename and restructure the function from CheckInvalidEGW to CheckInvalidVLENandLMUL. Repository

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 546677. 4vtomat added a comment. Update missing comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files: clang/include/clang/Basic/riscv_vector.td clang/in

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2405 + defvar suffix = !if(IsVV, "vv", "vi"); + defvar prototype = !if(IsVV, "UvUvUvUv", "UvUvUvKz"); + defm "" : RVVBuiltinSet; craig.topper wrote: > Can we split this into t

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 546671. 4vtomat marked 3 inline comments as done. 4vtomat added a comment. This update does a few things: 1. Update Craig's comments. 2. Make `LMUL=8` valid(https://github.com/riscv-non-isa/rvv-intrinsic-doc/pull/234#discussion_r1282568330). 3. Rebase. Rep

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4496 +static bool CheckInValidEGW(const TargetInfo &TI, CallExpr *TheCall, Sema &S, +QualType Type, int EGW) { InValid -> Invalid Comm

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 544624. 4vtomat marked 5 inline comments as done. 4vtomat added a comment. After discusstion in https://github.com/riscv-non-isa/rvv-intrinsic-doc/pull/234, we will have multiple lmuls for scalar type operands. Currently the test cases for those instructions

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); craig.topper wro

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); craig.topper wro

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vwsll.c:12 +// +vint16mf4_t test_vwsll_vv_i16mf4(vint8mf8_t op1, vint8mf8_t op2, size_t vl) { + return __riscv_vwsll_vv_i16mf4(op1, op2, vl);

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2405 + defvar suffix = !if(IsVV, "vv", "vi"); + defvar prototype = !if(IsVV, "UvUvUvUv", "UvUvUvKz"); + defm "" : RVVBuiltinSet; Can we split this into two classes and ge

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); eopXD wrote: > V

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

eopXD added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); Valid range of `vaeskf1

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat marked 2 inline comments as done. 4vtomat added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2378 + +multiclass RVVOutBuiltinSetP { craig.topper wrote: > What does `P` in this name mean? Is this because they use OP_P as their >

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 539402. 4vtomat marked 12 inline comments as done. 4vtomat added a comment. Resolved Craig's and Michael's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 F

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

michaelmaitland added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2381 + if HasVV then { +defvar suffix = !if(!or(HasVS, !eq(NAME, "vsm4r")), "vv", "v"); +// We don't need suffix in Zvkb extension since it's consider as normal

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

michaelmaitland added a comment. Can you please add a description for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 ___ cfe-commits mailing list c

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2378 + +multiclass RVVOutBuiltinSetP { What does `P` in this name mean? Is this because they use OP_P as their opcode? If so I don't think that should be part of how we nam

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 535696. 4vtomat added a comment. Herald added a subscriber: wangpc. Ready for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files: clang/include/clang/Basi

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat added a comment. Sorry for late reply, this is the relevant spec for C intrinsics: https://github.com/riscv-non-isa/rvv-intrinsic-doc/pull/234 I will update the patch according to this! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

asb added a comment. I just wanted to check on whether this is ready to review? Also, to what degree are these intrinsics standardised and where is the relevant specification for them? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/n

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 517113. 4vtomat added a comment. Update to version 0.5.1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files: clang/include/clang/Basic/riscv_vector.td clang/

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 508539. 4vtomat added a comment. Herald added subscribers: jobnoorman, luke. Updated to spec version 20230206. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files:

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 479144. 4vtomat added a comment. Fixed the comment from Craig Topper and Philip Reames Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files: clang/include/clang/Ba

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

asb added a comment. Thanks for sharing these patches. I appreciate you're probably not expecting in-depth reviews at this point, but if you could update the patch description to link to the current spec for these intrinsics it would be a lot easier for anyone who is able to give some early fee

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, s