Re: [PATCH] D13899: Fix bug in suggested fix that truncated variable names to 1 character.

2015-11-11 Thread Samuel Benzaquen via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252773: Fix bug in suggested fix that truncated variable names to 1 character. (authored by sbenza). Changed prior to commit: http://reviews.llvm.org/D13899?vs=37885&id=39944#toc Repository: rL LLVM

Re: [PATCH] D13899: Fix bug in suggested fix that truncated variable names to 1 character.

2015-11-11 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:25 @@ +24,3 @@ +template +static CharSourceRange removeNode(const MatchFinder::MatchResult &Result, + const T *PrevNode, const T *Node, sbe

Re: [PATCH] D13899: Fix bug in suggested fix that truncated variable names to 1 character.

2015-11-11 Thread Samuel Benzaquen via cfe-commits
sbenza added inline comments. Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:25 @@ +24,3 @@ +template +static CharSourceRange removeNode(const MatchFinder::MatchResult &Result, + const T *PrevNode, const T *Node, aaron.ball

Re: [PATCH] D13899: Fix bug in suggested fix that truncated variable names to 1 character.

2015-11-01 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:25 @@ +24,3 @@ +template +static CharSourceRange removeNode(const MatchFinder::MatchResult &Result,

[PATCH] D13899: Fix bug in suggested fix that truncated variable names to 1 character.

2015-10-20 Thread Samuel Benzaquen via cfe-commits
sbenza created this revision. sbenza added reviewers: alexfh, aaron.ballman. sbenza added a subscriber: cfe-commits. Fix bug in suggested fix that truncated variable names to 1 character. Also, rework the suggested fix to try to remove unnecessary whitespace. http://reviews.llvm.org/D13899 Files