This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1a8dd7425873: [include-cleaner] clang-include-cleaner can
print/apply edits (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES
sammccall added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:77
+ bool Satisfied = false;
+ for (const Header &H : Providers) {
+ if (H.kind() == Header::Physical && H.physical() == MainFile)
---
kadircet accepted this revision.
kadircet added a comment.
thanks!
Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:77
+ bool Satisfied = false;
+ for (const Header &H : Providers) {
+ if (H.kind() == Header::Physical && H.phy
sammccall updated this revision to Diff 479575.
sammccall added a comment.
delete dead code, add comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139013/new/
https://reviews.llvm.org/D139013
Files:
clang-tools-extra/include-cleaner/include/
sammccall added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:65
+llvm::ArrayRef MacroRefs,
+const Includes &, const PragmaIncludes *PI,
+const Sourc
sammccall updated this revision to Diff 479574.
sammccall marked an inline comment as done.
sammccall added a comment.
Herald added a project: clang.
replace fixIncludes impl with clang-format, tweak tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:65
+llvm::ArrayRef MacroRefs,
+
sammccall updated this revision to Diff 478984.
sammccall added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139013/new/
https://reviews.llvm.org/D139013
Files:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/A
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added a subscriber: mgrang.
Herald added a project: All.
sammccall requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
This adds command-line flags to the