Hahnfeld added a comment.
SGTM
https://reviews.llvm.org/D13909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Hi Jonas,
Thanks again for the review!
Comment at: test/CMakeLists.txt:27-33
@@ -26,8 +26,9 @@
list(APPEND CLANG_TEST_DEPS
clang clang-headers
clang-format
c-index-test diagtool
clang-tblgen
+ clang-offload-bundler
)
-
sfantao updated this revision to Diff 69124.
sfantao marked an inline comment as done.
sfantao added a comment.
- Add clang-offload bundler as dependency to clang.
https://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bundler.c
tools/CMakeLists.txt
tools/c
Hahnfeld added inline comments.
Comment at: test/CMakeLists.txt:27-33
@@ -26,8 +26,9 @@
list(APPEND CLANG_TEST_DEPS
clang clang-headers
clang-format
c-index-test diagtool
clang-tblgen
+ clang-offload-bundler
)
Most users will get it anyway b
sfantao added a comment.
Hi Jonas,
Thanks for the review!
Comment at: test/CMakeLists.txt:27-33
@@ -26,8 +26,9 @@
list(APPEND CLANG_TEST_DEPS
clang clang-headers
clang-format
c-index-test diagtool
clang-tblgen
+ clang-offload-bundler
)
Ha
sfantao updated this revision to Diff 68086.
sfantao marked 5 inline comments as done.
sfantao added a comment.
- Fix comments and diagnostics.
https://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bundler.c
tools/CMakeLists.txt
tools/clang-offload-bundler
Hahnfeld accepted this revision.
Hahnfeld added a reviewer: Hahnfeld.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
LGTM with only some minor nits on some of the comments and a CMake question
Comment at: test/CMakeLists.txt:27-33
@@ -26,8 +26,9 @@
sfantao updated this revision to Diff 66023.
sfantao added a comment.
- Fix bug in conditional.
- Rebase.
https://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bundler.c
tools/CMakeLists.txt
tools/clang-offload-bundler/CMakeLists.txt
tools/clang-offload-
sfantao updated this revision to Diff 63362.
sfantao added a comment.
- Add tests for when the host does not come first.
- Fix format of comments and add variable to trace the position of the host
input.
http://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bu
sfantao updated this revision to Diff 62540.
sfantao added a comment.
- Remove \brief when not needed.
http://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bundler.c
tools/CMakeLists.txt
tools/clang-offload-bundler/CMakeLists.txt
tools/clang-offload-bund
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: test/Driver/clang-offload-bundler.c:14
@@ +13,3 @@
+//
+// RUN: touch %t.empty
+
ABataev wrote:
> Hmm, will it work on Windows? Maybe it is better just to add an empty test
> file?
I see ma
sfantao updated this revision to Diff 62538.
sfantao marked 9 inline comments as done.
sfantao added a comment.
- Merge branch 'master' into patch-D13909
- Remove unecessary returns and fix iterators.
http://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bundle
ABataev added a comment.
Remove empty 'return' and ';' statements where they are not required.
Comment at: test/Driver/clang-offload-bundler.c:14
@@ +13,3 @@
+//
+// RUN: touch %t.empty
+
Hmm, will it work on Windows? Maybe it is better just to add an empty test
sfantao updated this revision to Diff 62249.
sfantao added a comment.
Herald added a subscriber: mehdi_amini.
- Reorganize file handlers. Generate empty files if no components exist in the
bundle instead of just failing.
http://reviews.llvm.org/D13909
Files:
test/Driver/clang-offload-bundler
sfantao updated this revision to Diff 40999.
sfantao updated the summary for this revision.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D13909
Files:
tools/CMakeLists.txt
tools/Makefile
tools/clang-offload-bundler/CMakeLists.txt
tools/clang-offload-bundler/ClangOffloadBundl
sfantao updated this revision to Diff 39590.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D13909
Files:
tools/CMakeLists.txt
tools/Makefile
tools/clang-offload-bundler/CMakeLists.txt
tools/clang-offload-bundler/ClangOffloadBundler.cpp
tools/clang-offload-bundler/Makefile
sfantao created this revision.
sfantao added reviewers: hfinkel, rsmith, echristo, ABataev, chandlerc.
sfantao added a subscriber: cfe-commits.
One of the goals of programming models that support offloading (e.g. OpenMP) is
to enable users to offload with little effort, by annotating the code wit
17 matches
Mail list logo
