carlosgalvezp updated this revision to Diff 481257.
carlosgalvezp added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139113/new/
https://reviews.llvm.org/D139113
Files:
clang-tools-extra/clang-tidy/misc/UseAnonymousNamespaceCh
carlosgalvezp added a comment.
Friendly ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139113/new/
https://reviews.llvm.org/D139113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
vingeldal accepted this revision.
vingeldal added inline comments.
This revision is now accepted and ready to land.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/misc/use-anonymous-namespace.cpp:46-48
+// OK
+static const int v8{123};
+static constexpr int v9{123};
carlosgalvezp added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/misc/use-anonymous-namespace.cpp:46-48
+// OK
+static const int v8{123};
+static constexpr int v9{123};
vingeldal wrote:
> Is it really the best behavior to allow these?
This revision was automatically updated to reflect the committed changes.
Closed by commit rG35d9f873e3f2: [clang-tidy] Fix a couple additional cases in
misc-use-anonymous-namespace only (authored by carlosgalvezp).
Changed prior to commit:
https://reviews.llvm.org/D139113?vs=481257&id=482119#t