[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar marked an inline comment as done. fahadnayyar added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14115 +/// Analyze the given compound assignment for the possible losing of +/// floating-point precision. aaron.ballman wrote: > Moving

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

aaron.ballman added a reviewer: libc++. aaron.ballman added a comment. It looks like this change breaks libc++ (see the precommit CI failures) by making more changes than expected. I'm now seeing `implicit conversion changes signedness` diagnostics where we didn't previously get them. Is that ex

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 486897. fahadnayyar marked an inline comment as done. fahadnayyar added a comment. Herald added a project: libunwind. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libunwind. Fixed libcxx failure and added test case for expected warni

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar marked 2 inline comments as done. fahadnayyar added a comment. In D139114#4023456 , @aaron.ballman wrote: > It looks like this change breaks libc++ (see the precommit CI failures) by > making more changes than expected. I'm now seeing `impli

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 486930. fahadnayyar marked an inline comment as done. fahadnayyar added a comment. Added summary in clang release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D1

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 482102. fahadnayyar added a comment. Added forward declare for CheckImplicitConversion to make the diff look clean. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 479626. fahadnayyar retitled this revision from "[Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator. " to "[Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.". fahadnayyar added a comment. Fixing clang-format er

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14115 +/// Analyze the given compound assignment for the possible losing of +/// floating-point precision. Moving this function to another spot in the file makes comparing the new

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator. This change enables Wshorten-64-to-32 waring for compound assignment statements which has implicit conversion

fahadnayyar created this revision. Herald added a project: All. fahadnayyar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...://10466193 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139114 Files: clang/lib/Sema/Se