benlangmuir added a comment.
libclang changes LGTM, thanks! I'll let the other reviewers who have domain
expertise speak for the rest of the patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139115/new/
https://reviews.llvm.org/D139115
__
benlangmuir added a comment.
Thanks, the libclang change LGTM other than my comment about the function names.
Comment at: clang/include/clang-c/Documentation.h:589
+ */
+CINDEX_LINKAGE CXString clang_getSingleSymbolSymbolGraphForUSR(const char *usr,
+
dang marked an inline comment as done.
dang added inline comments.
Comment at: clang/include/clang/ExtractAPI/DeclarationFragments.h:91
+/// The associated declaration, if applicable.
+const Decl *Declaration;
+
zixuw wrote:
> Is the decl guaranteed to be
akyrtzi added inline comments.
Comment at: clang/include/clang-c/Documentation.h:549
+typedef struct CXAPISetImpl *CXAPISet;
+
benlangmuir wrote:
> @dang please document what this type represents.
>
> @akyrtzi what's the preferred implementation type name for
benlangmuir added subscribers: akyrtzi, benlangmuir.
benlangmuir added inline comments.
Comment at: clang/include/clang-c/Documentation.h:549
+typedef struct CXAPISetImpl *CXAPISet;
+
@dang please document what this type represents.
@akyrtzi what's the preferr
dang marked 6 inline comments as done.
dang added inline comments.
Comment at: clang/include/clang/ExtractAPI/API.h:234
ReadOnly = 1,
-Class = 1 << 1,
Dynamic = 1 << 2,
zixuw wrote:
> What's the reason for refactoring out instance vs. class property
zixuw added inline comments.
Comment at: clang/include/clang/ExtractAPI/API.h:128-130
+ /// Store hierarchy information for a given record.
+ ///
+ /// This is roughly analogous to the DeclContext hierarchy for an AST Node.
Misplaced comment?
===
