[PATCH] D139122: Generalize clang-tidy modernize-pass-by-value

2023-02-05 Thread Chris Cotter via Phabricator via cfe-commits
ccotter added a comment. https://reviews.llvm.org/D137205 looks to be similar in part, as it applies a FixIt to a any last use of an object if the use a copy, including parameters and local objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D139122: Generalize clang-tidy modernize-pass-by-value

2023-02-05 Thread Chris Cotter via Phabricator via cfe-commits
ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp:11 +#include "../utils/Aliasing.h" +#include "../utils/ExprSequence.h" #include "clang/AST/ASTContext.h" I think you need to add `clangAnalysis` (for Analysis/

[PATCH] D139122: Generalize clang-tidy modernize-pass-by-value

2022-12-01 Thread Martin Bidlingmaier via Phabricator via cfe-commits
mbid created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. mbid added a comment. mbid published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Hi Nathan, Could