[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:48 NamedDecl *resolveType(QualType Type) { if (Type->isPointerType()) please rebase the patch, this API is changed in https://github.com/llvm/llvm-project/commi

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 483881. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-too

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:51 Type = Type->getPointeeType(); +if (const TemplateSpecializationType *TST = +Type->getAs()) { hokein wrote: > nit: we can u

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 483882. VitaNuo added a comment. Remove unusued include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e545816a9e5: [include-cleaner] Handle dependent type members in AST. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Handles dependent type members in AST. Repository: rG LLVM Github Monor

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480466. VitaNuo added a comment. Implement dependent type handling for template specialization types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-t

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480467. VitaNuo added a comment. Remove extra import. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp cla

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480469. VitaNuo added a comment. Adjust implementation to handle pointer types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cle

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480528. VitaNuo added a comment. Add handling of nested types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480530. VitaNuo added a comment. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp cla

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480539. VitaNuo added a comment. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp cla

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:67 + bool VisitCXXDependentScopeMemberExpr(CXXDependentScopeMemberExpr *E) { +QualType QT = E->getBaseType().getCanonicalType(); Rebase the current patch. Move the

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 481659. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-too

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:79 + +if (isa(UnqualifiedType)) { + const TemplateSpecializationType *TST = hokein wrote: > if we just aim to support t

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

hokein added a comment. thanks, looks mostly good, I think we can simplify the unittest further. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:51 Type = Type->getPointeeType(); +if (const TemplateSpecializationType *TST = +Type->getAs()) {