[PATCH] D139458: [clangd] Full support for #import insertions

2023-01-09 Thread David Goldman via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG042dd99484d6: [clangd] Full support for #import insertions (authored by dgoldman). Changed prior to commi

[PATCH] D139458: [clangd] Full support for #import insertions

2023-01-09 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 __

[PATCH] D139458: [clangd] Full support for #import insertions

2023-01-05 Thread David Goldman via Phabricator via cfe-commits
dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:572 + // case where a header file contains ObjC decls but no #imports. + Symbol::IncludeDirective Directive = preferredIncludeDirective( +

[PATCH] D139458: [clangd] Full support for #import insertions

2023-01-05 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 486706. dgoldman added a comment. Respect ImportInsertions flag in IncludeFixer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-extra/clangd/AST

[PATCH] D139458: [clangd] Full support for #import insertions

2023-01-05 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet requested changes to this revision. kadircet added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:572 + // case where a header file contains ObjC decls but no #imports. + Symbol::IncludeDirecti

[PATCH] D139458: [clangd] Full support for #import insertions

2023-01-04 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 486291. dgoldman marked 4 inline comments as done. dgoldman added a comment. Update comment + test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-too

[PATCH] D139458: [clangd] Full support for #import insertions

2023-01-03 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/AST.h:122 +/// Returns the Include Directive which should be used for include insertions +/// for the given main file.

[PATCH] D139458: [clangd] Full support for #import insertions

2023-01-03 Thread David Goldman via Phabricator via cfe-commits
dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:88 /// (These should be const, but RecursiveASTVisitor requires Decl*). - ArrayRef getLocalTopLevelDecls(); + ArrayRef getLocalTopLevelDecls() const; kadircet wrote: > can you

[PATCH] D139458: [clangd] Full support for #import insertions

2023-01-03 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 486111. dgoldman marked 7 inline comments as done. dgoldman added a comment. Minor fixes for review, moving stuff around Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D1394

[PATCH] D139458: [clangd] Full support for #import insertions

2023-01-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/ASTSignals.h:39 + + static Symbol::IncludeDirective preferredIncludeDirective( + llvm::StringRef Filename, const LangOptions &LangOpts, could you rather move this to `AST.h`, with some com

[PATCH] D139458: [clangd] Full support for #import insertions

2022-12-15 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 483205. dgoldman added a comment. Don't pass ASTSignals through ParsedAST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-extra/clangd/ASTSignal

[PATCH] D139458: [clangd] Full support for #import insertions

2022-12-14 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 482950. dgoldman marked 5 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-ex

[PATCH] D139458: [clangd] Full support for #import insertions

2022-12-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/ASTSignals.cpp:28 + // Source files: Use #import if the ObjC language flag is enabled + if (isHeaderFile(AST.tuPath(), AST.getLangOpts())) { +if (AST.getLangOpts().ObjC) { can we rewrite t

[PATCH] D139458: [clangd] Full support for #import insertions

2022-12-07 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 481022. dgoldman added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-extra/clangd/ASTSignals.cpp clang-tools-extra/clan

[PATCH] D139458: [clangd] Full support for #import insertions

2022-12-06 Thread David Goldman via Phabricator via cfe-commits
dgoldman created this revision. Herald added subscribers: kadircet, arphaman, javed.absar. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. These are still disabled by