[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

2023-10-25 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69209e30a716: [clang-format] AllowShortCompoundRequirementOnASingleLine (authored by Backl1ght, committed by owenpan). Changed prior to commit: h

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

2023-05-15 Thread Emilia Kond via Phabricator via cfe-commits
rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. I see nothing wrong with this patch alone as it currently stands, since it's a quite simple change to the LineJoiner, and I see it as one of the final stopgaps in clang-format's support for re

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

2023-03-11 Thread Emilia Dreamer via Phabricator via cfe-commits
rymiel added inline comments. Comment at: clang/lib/Format/Format.cpp:809 Style.AllowShortCaseLabelsOnASingleLine); +IO.mapOptional("AllowShortCompoundRequirementOnASingleLine", + Style.AllowShortCompoundRequirementOnASingleLine); ---

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

2022-12-14 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1265 LLVMStyle.AllowShortCaseLabelsOnASingleLine = false; + LLVMStyle.AllowShortCompoundRequirementOnASingleLine = true; LLVMStyle.AllowShortEnumsOnASingleLine = true; HazardyKnu

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

2022-12-13 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1265 LLVMStyle.AllowShortCaseLabelsOnASingleLine = false; + LLVMStyle.AllowShortCompoundRequirementOnASingleLine = true; LLVMStyle.AllowShortEnumsOnASingleLine = true; MyDeve

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

2022-12-13 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1265 LLVMStyle.AllowShortCaseLabelsOnASingleLine = false; + LLVMStyle.AllowShortCompoundRequirementOnASingleLine = true; LLVMStyle.AllowShortEnumsOnASingleLine = true; Backl1ght

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

2022-12-13 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added inline comments. Comment at: clang/lib/Format/Format.cpp:809 Style.AllowShortCaseLabelsOnASingleLine); +IO.mapOptional("AllowShortCompoundRequirementOnASingleLine", + Style.AllowShortCompoundRequirementOnASingleLine);

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

2022-12-12 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:809 Style.AllowShortCaseLabelsOnASingleLine); +IO.mapOptional("AllowShortCompoundRequirementOnASingleLine", + Style.AllowShortCompoundRequirementOnASingleLine);

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

2022-12-12 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. See the comments on D139786 . And you can base your commits on each other, and then add a child rsp. parent revision here in phabricator, that will prevent merge conflicts. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

2022-12-12 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght created this revision. Backl1ght added reviewers: HazardyKnusperkeks, rymiel. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-format brace wrapp