This revision was automatically updated to reflect the committed changes.
Closed by commit rG5cf85323a078: [clang][analyzer] Extend StreamChecker with
some new functions. (authored by balazske).
Changed prior to commit:
https://reviews.llvm.org/D140395?vs=485928&id=486797#toc
Repository:
rG
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140395/new/
https://reviews.llvm.org/D140395
_
Szelethus added a comment.
Mostly LGTM, but I see that you have tests for the predecessor patch here as
well, so I'll accept both at once.
Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:89
/// The last file operation called in the stream.
+ /// Can be null
balazske updated this revision to Diff 485928.
balazske marked 2 inline comments as done.
balazske added a comment.
Removed old commment, updated a test run line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140395/new/
https://reviews.llvm.org/D1
Szelethus added a comment.
Does this patch fix any false positives from before, or is this just all new
stuff? I ask, because I wonder whats the shortest path towards popping these
checkers out of alpha, and fix what we already have. By no means am I saying
that we should postpone landing this,
balazske created this revision.
Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411,
dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet,
baloghadamsoftware, xazax.hun.
Herald added a reviewer: Szelethus.
Herald added a reviewer: NoQ.
Herald added a project:
