[PATCH] D140543: [clang-format] Add an option to format integer literal separators

aaron.ballman added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3168-3171 + Separator format of integer literals of different bases. + <0: Remove separators. + 0: Leave the literal as is. + >0: Insert separators between digits, starting from the

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89aad1e6a397: Reland [clang-format] Add an option to format integer literal separators (authored by owenpan). Repository: rG LLVM Github Monorepo

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:81-82 + + llvm::SpecificBumpPtrAllocator Allocator; + auto Tok = new

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan requested review of this revision. owenpan added inline comments. Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:81-82 + + llvm::SpecificBumpPtrAllocator Allocator; + auto Tok = new (Allocator.Allocate()) Token; + Lex->LexFromRawLexer(*Tok);

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 485658. owenpan added a comment. It turns out that the memory bug had nothing to do with whether to use the stack or heap memory for the `Token` object. The culprit was passing `getFormattingLangOpts(Style)` directly to the `Lexer` constructor. I suppose

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:81-82 + + llvm::SpecificBumpPtrAllocator Allocator; + auto Tok = new

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan requested review of this revision. owenpan added a comment. In D140543#4016184 , @thakis wrote: > In D140543#4016181 , @owenpan wrote: > >> In D140543#4016156 ,

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 485600. owenpan added a comment. Fix a memory bug, which doesn't surface in Debug build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Introduces memory bugs: https://lab.llvm.org/buildbot/#/builders/5/builds/30234 https://lab.llvm.org/buildbot/#/builders/236/builds/1556 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

thakis added a comment. It was also failing on the official bots: https://lab.llvm.org/buildbot/#/builders/109/builds/54291 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

thakis added a comment. In D140543#4016181 , @owenpan wrote: > In D140543#4016156 , @thakis wrote: > >> This seems to break tests everywhere, eg >> http://45.33.8.238/linux/95289/step_7.txt >> >> Please take a

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan added a comment. In D140543#4016156 , @thakis wrote: > This seems to break tests everywhere, eg > http://45.33.8.238/linux/95289/step_7.txt > > Please take a look and revert for now if it takes a while to fix. I had run FormatTests on Windows

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

thakis added a comment. This seems to break tests everywhere, eg http://45.33.8.238/linux/95289/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46c94e5067b5: [clang-format] Add an option to format integer literal separators (authored by owenpan). Repository: rG LLVM Github Monorepo

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 485210. owenpan added a comment. Cleaned up the unit tests a little bit: - Made them a little more varied. - Removed some overlapping test cases. - Removed integer literal suffixes for JavaScript. - Added an octal `BigInt` test case for JavaScript. CHANGES

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 485188. owenpan added a comment. This revision is now accepted and ready to land. - Fixed an assertion failure. - Added unit tests . - Moved all unit tests to another file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan planned changes to this revision. owenpan added a comment. Will add more unit tests and perhaps move them to their own file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 ___ cfe-commits

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 485180. owenpan added a comment. This revision is now accepted and ready to land. - Adds support for C#, Java, and JavaScript using `_`. - Adds support for only formatting affected ranges. - Simplifies ``IntegerLiteralSeparatorFixer::format()``. - Adds more

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan planned changes to this revision. owenpan added a comment. Will extend this option to support C#, Java, and JavaScript using the underscore character `_` as the separator. Comment at: clang/unittests/Format/FormatTest.cpp:25124 +TEST_F(FormatTest,

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTest.cpp:25124 +TEST_F(FormatTest, IntegerLiteralSeparator) { + FormatStyle Style = getLLVMStyle();

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:2395 + /// >0: Insert separators between digits, starting from the rightmost digit. + struct IntegerLiteralSeparatorStyle { +/// \code

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 484841. owenpan added a comment. Fixed another bug and added some unit tests. Also updated ReleaseNotes.rst and addressed some review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 Files:

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2395 + /// >0: Insert separators between digits, starting from the rightmost digit. + struct IntegerLiteralSeparatorStyle { +/// \code Also add Octal?

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

MyDeveloperDay added a comment. does it have any unit tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 484801. owenpan added a comment. Fixes a couple of bugs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan planned changes to this revision. owenpan added a comment. Will add unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 ___ cfe-commits mailing

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Closes