[PATCH] D140743: [DFSan] Fix overuse of REQUIRES: in tests.

2022-12-29 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:766 Res |= SanitizerKind::SafeStack; - if (IsX86_64 || IsMIPS64 || IsAArch64) + if (IsX86_64) Res |= SanitizerKind::DataFlow; This change is still useful and worth

[PATCH] D140743: [DFSan] Fix overuse of REQUIRES: in tests.

2022-12-29 Thread Andrew via Phabricator via cfe-commits
browneee abandoned this revision. browneee added a comment. Abandon due to D140744 being submitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140743/new/ https://reviews.llvm.org/D140743

[PATCH] D140743: [DFSan] Fix overuse of REQUIRES: in tests.

2022-12-28 Thread Andrew via Phabricator via cfe-commits
browneee updated this revision to Diff 485552. browneee added a comment. Fix other line number. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140743/new/ https://reviews.llvm.org/D140743 Files: clang/lib/Driver/ToolChains/Linux.cpp

[PATCH] D140743: [DFSan] Fix overuse of REQUIRES: in tests.

2022-12-28 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140743/new/ https://reviews.llvm.org/D140743

[PATCH] D140743: [DFSan] Fix overuse of REQUIRES: in tests.

2022-12-28 Thread Andrew via Phabricator via cfe-commits
browneee updated this revision to Diff 485547. browneee added a comment. Fix updated line numbers in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140743/new/ https://reviews.llvm.org/D140743 Files: clang/lib/Driver/ToolChains/Linux.cpp

[PATCH] D140743: [DFSan] Fix overuse of REQUIRES: in tests.

2022-12-28 Thread Andrew via Phabricator via cfe-commits
browneee created this revision. browneee added a reviewer: MaskRay. Herald added subscribers: Enna1, StephenFan. Herald added a project: All. browneee requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Following