[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

junaire updated this revision to Diff 485654. junaire added a comment. Update patch according to @ymandel 's suggestion. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140753/new/ https://reviews.llvm.org/D140753 Files:

[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

junaire added a comment. In D140753#4019322 , @gribozavr2 wrote: > Thank you for your contribution! > > While adding a conditional check fixes the crash, the problem's root cause > must be deeper. Mismatched types indicate that one code path in

[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

gribozavr2 requested changes to this revision. gribozavr2 added a comment. This revision now requires changes to proceed. Thank you for your contribution! While adding a conditional check fixes the crash, the problem's root cause must be deeper. Mismatched types indicate that one code path in

[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

junaire created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously we assume RHS is a BoolValue if LHS