[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGd227c3b68cf5: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros (authored by brad). Changed prior to commit: https://reviews.llvm.org/D140757?vs=485743=486501#toc Repository:

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:4337 +// RUN: %clang -E -dM %s -o - 2>&1 \ +// RUN: -target hexagon-unknown-linux \ +// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_HEXAGON_ATOMICS

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:4337 +// RUN: %clang -E -dM %s -o - 2>&1 \ +// RUN: -target hexagon-unknown-linux \ +// RUN: | FileCheck -match-full-lines %s

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

aheejin accepted this revision. aheejin added a comment. All Wasm atomics are sequentially consistent; If that's supported by this macro, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140757/new/ https://reviews.llvm.org/D140757

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

kparzysz accepted this revision. kparzysz added a comment. This revision is now accepted and ready to land. All of Hexagon's atomics are implemented using load-locked/store-conditional. If that meets the expectations of these macros, then this is fine with me. Repository: rG LLVM Github

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad updated this revision to Diff 485743. brad added a comment. Remove some whitespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140757/new/ https://reviews.llvm.org/D140757 Files: clang/lib/Basic/Targets/Hexagon.cpp

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad updated this revision to Diff 485607. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140757/new/ https://reviews.llvm.org/D140757 Files: clang/lib/Basic/Targets/Hexagon.cpp clang/lib/Basic/Targets/VE.cpp

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad created this revision. brad added reviewers: kparzysz, kaz7, simoll, aheejin, luke. brad added a project: clang. Herald added subscribers: pmatos, asb, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: All. brad requested review of this revision. Define