tlively accepted this revision.
tlively added inline comments.
Comment at: llvm/test/CodeGen/WebAssembly/simd-shuffle.ll:1-2
+; RUN: llc < %s -asm-verbose=false -verify-machineinstrs
-disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals
-wasm-keep-registers
penzn marked an inline comment as done.
penzn added a comment.
Moved the test out.
Comment at: llvm/test/CodeGen/WebAssembly/simd-shuffle.ll:1-2
+; RUN: llc < %s -asm-verbose=false -verify-machineinstrs
-disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals
penzn updated this revision to Diff 486636.
penzn edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140773/new/
https://reviews.llvm.org/D140773
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/Headers/wasm_simd128.h
tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.
LGTM % comment. Thanks for taking this!
Comment at: llvm/test/CodeGen/WebAssembly/simd-intrinsics.ll:159-160
; CHECK-NEXT: return $pop[[R]]{{$}}
-declare <16 x i8>
penzn added a comment.
I still need to run a few external tests, like the ones mentioned in
https://github.com/emscripten-core/emscripten/issues/9340
https://github.com/WebAssembly/simd/issues/196
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
penzn created this revision.
penzn added a reviewer: tlively.
Herald added subscribers: pmatos, asb, ecnelises, sunfish, hiraditya,
jgravelle-google, sbc100, dschuff.
Herald added a project: All.
penzn requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits,
