madanial added a comment.
Thanks for the review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140795/new/
https://reviews.llvm.org/D140795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1360bfb05b31: [Flang] Add user option
-funderscoring/-fnounderscoring to control trailing… (authored by madanial).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
clementval accepted this revision.
clementval added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for working on this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140795/new/
https://reviews.llvm.org/D140795
___
madanial updated this revision to Diff 497931.
madanial added a comment.
addressing style mismatch in > flang/include/flang/Tools/CLOptions.inc
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140795/new/
https://reviews.llvm.org/D140795
Files:
clang/include/clang/Driver/Options.td
clementval added a comment.
You still have style mismatch in `flang/include/flang/Tools/CLOptions.inc`.
This file is likely not run through clang-format so that's why.
Comment at: flang/include/flang/Tools/CLOptions.inc:214
+llvm::OptimizationLevel optLevel =
madanial updated this revision to Diff 497928.
madanial added a comment.
Bug Fix for failing test cases
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140795/new/
https://reviews.llvm.org/D140795
Files:
clang/include/clang/Driver/Options.td
clang/lib/Driver/ToolChains/Flang.cpp
clementval added a comment.
The pre-commit check is still failing with these tests:
Flang :: Fir/alloc.fir
Flang :: Fir/embox.fir
Flang :: Fir/optional.fir
Flang :: Fir/rebox.fir
Flang :: Lower/common-block.f90
Flang :: Lower/forall/character-1.f90
CHANGES SINCE LAST ACTION
madanial updated this revision to Diff 497392.
madanial added a comment.
clang-format issue in
ExternalNameConversion.cpp
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140795/new/
https://reviews.llvm.org/D140795
Files:
clang/include/clang/Driver/Options.td
clementval added a comment.
You still have clang-format issues in your patch. Can you update that.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140795/new/
https://reviews.llvm.org/D140795
___
cfe-commits mailing list
madanial updated this revision to Diff 497024.
madanial added a comment.
Addressing the review comments relating to the test case. Thanks for the catch!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140795/new/
https://reviews.llvm.org/D140795
Files:
clementval added inline comments.
Comment at: flang/test/Fir/external-mangling.fir:36
+
+// CHECK-NOUNDER: func @foo
+// CHECK-NOUNDER: %{{.*}} = fir.address_of(@a) : !fir.ref>
You should check at least the character after it because here the check line
would
madanial updated this revision to Diff 496027.
madanial added a comment.
Rebase, as well as bug fix relating to the ExternalNameConversion pass option
that was exposed by the requested fir-opt test case. The pass option was being
overwritten by default value whenever it was called through
awarzynski added a comment.
Driver changes LGTM, thanks! I will defer to others for changes in other areas.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140795/new/
https://reviews.llvm.org/D140795
___
cfe-commits mailing list
clementval added a comment.
Can you also add test in `flang/test/Fir/external-mangling.fir`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140795/new/
https://reviews.llvm.org/D140795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
madanial updated this revision to Diff 492463.
madanial added a comment.
Addressing review comment
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140795/new/
https://reviews.llvm.org/D140795
Files:
clang/include/clang/Driver/Options.td
clang/lib/Driver/ToolChains/Flang.cpp
clementval added a comment.
Small suggestion
Comment at: flang/lib/Optimizer/Transforms/ExternalNameConversion.cpp:41-45
+ std::string newName{result.second.name};
+ if (appendUnderscore)
+newName = newName + "_";
+
+ return newName;
To avoid new copy
madanial updated this revision to Diff 492312.
madanial retitled this revision from "[Flang] Add user option
-funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass"
to "[Flang] Add user option -funderscoring/-fnounderscoring to control trailing
underscore added to external
17 matches
Mail list logo