[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

clementval added a comment. You should have a look at https://mlir.llvm.org/docs/PassManagement/#instance-specific-pass-options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

kkwli0 added a comment. In D140795#4033559 , @awarzynski wrote: >> However, I don't think the patch does what we want. Given a procedure name >> `foo`, the `-fno-underscoring` option will give `_QPfoo` instead of `foo`. >> We will look into it. > >

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

awarzynski added a comment. In D140795#4031392 , @kkwli0 wrote: > The purpose of this option is to control the trailing underscore being > appended to external names (e.g. procedure names, common block names). The > option in gfortran is documented in

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

kkwli0 added a comment. In D140795#4022493 , @awarzynski wrote: > Hi @madanial , thanks for posting this! > >> This patch adds user option -funderscoring/-fnounderscoring which behaves >> similar to the gfortran option be enabling/disabling the >>

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

awarzynski added a comment. Hi @madanial , thanks for posting this! > This patch adds user option -funderscoring/-fnounderscoring which behaves > similar to the gfortran option be enabling/disabling the > ExternalNameConversionPass I don't quite understand what this option is for and it's

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

clementval requested changes to this revision. clementval added a comment. This revision now requires changes to proceed. You need to update the driver-help tests. Comment at: flang/include/flang/Tools/CLOptions.inc:194 #if !defined(FLANG_EXCLUDE_CODEGEN) -inline void