vvereschaka added a comment.
Hi @brad,
thank you for fixing the broken tests.
There is still a problem with `netbsd.c` test:
https://lab.llvm.org/buildbot/#/builders/60/builds/10135/steps/9/logs/FAIL__Clang__netbsd_c
Here:
// DRIVER-PASS-INCLUDES-SAME: {{^}} "-internal-isystem"
"[[RESOURCE]]
vvereschaka added a comment.
Hi @brad ,
would you fix the tests
https://lab.llvm.org/buildbot/#/builders/60/builds/10125
looks like the problem is here:
// DRIVER-PASS-INCLUDES: "-internal-externc-isystem" "/usr/include"
could be another path instead of "/usr/include".
this one should
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe449e1dff9f8: [Driver] move NetBSD header search path
management to the driver (authored by brad).
Repository:
rG LLVM Github Monorepo
CHANGES SI
brad updated this revision to Diff 486505.
brad added a comment.
Tweak test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140817/new/
https://reviews.llvm.org/D140817
Files:
clang/lib/Driver/ToolChains/NetBSD.cpp
clang/lib/Driver/ToolChains/N
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140817/new/
https://reviews.llvm.org/D140817
__
brad created this revision.
brad added reviewers: MaskRay, mgorny, krytarowski.
brad added a project: clang.
Herald added subscribers: StephenFan, ormris, arichardson, emaste.
Herald added a project: All.
brad requested review of this revision.
This matches OpenBSD and FreeBSD.
Repository:
rG
