[PATCH] D140843: [clang-format] fix template closer followed by >

MyDeveloperDay added a comment. In D140843#4029641 , @owenpan wrote: > In D140843#4028142 , > @MyDeveloperDay wrote: > >> I'd like one of @owenpan, @HazardyKnusperkeks or @rymiel to comment before >> commit, ju

[PATCH] D140843: [clang-format] fix template closer followed by >

This revision was automatically updated to reflect the committed changes. Closed by commit rGb62906b0d10f: [clang-format] fix template closer followed by > (authored by Backl1ght). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140843/new/ https://re

[PATCH] D140843: [clang-format] fix template closer followed by >

owenpan added a comment. In D140843#4028142 , @MyDeveloperDay wrote: > I'd like one of @owenpan, @HazardyKnusperkeks or @rymiel to comment before > commit, just to get another view. Perhaps clang-format should never insert a space in `>>`. CHANGES S

[PATCH] D140843: [clang-format] fix template closer followed by >

MyDeveloperDay accepted this revision. MyDeveloperDay added a subscriber: rymiel. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, thank you for adding an annotator test, I'd like one of @owenpan, @HazardyKnusperkeks or @rymiel to comment before commit, just

[PATCH] D140843: [clang-format] fix template closer followed by >

Backl1ght added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:169-171 +CurrentToken->getStartOfNonWhitespace() == +CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( +-1)) { MyDevelop

[PATCH] D140843: [clang-format] fix template closer followed by >

Backl1ght updated this revision to Diff 486248. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140843/new/ https://reviews.llvm.org/D140843 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp clang/unittests/Format/TokenAnnotatorTest.cpp Index: clang/u

[PATCH] D140843: [clang-format] fix template closer followed by >

Backl1ght added a comment. In D140843#4022673 , @MyDeveloperDay wrote: > I'm good with this but I'd be interesting in @owenpan and > @HazardyKnusperkeks opinion. Yes, this is what I understand. And I will add an annotator test later. This patch is j

[PATCH] D140843: [clang-format] fix template closer followed by >

MyDeveloperDay added a comment. I'm good with this but I'd be interesting in @owenpan and @HazardyKnusperkeks opinion. Comment at: clang/lib/Format/TokenAnnotator.cpp:169-171 +CurrentToken->getStartOfNonWhitespace() == +CurrentToken->Next->getStart

[PATCH] D140843: [clang-format] fix template closer followed by >

Backl1ght created this revision. Backl1ght added reviewers: HazardyKnusperkeks, MyDeveloperDay. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is to