This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3677ee65d192: Move from llvm::makeArrayRef to ArrayRef
deduction
serge-sans-paille updated this revision to Diff 486172.
serge-sans-paille added a comment.
Split the original patch in pieces: first just introduce the deduction guide.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140896/new/
https://reviews.llvm.org/D140896
Files:
MaskRay accepted this revision.
MaskRay added a comment.
LGTM if `makeArrayRef` is kept in this patch. Do we foresee compiler bugs (for
supported compilers) in this area? If there may be a risk, consider migrate a
part of the code base first.
CHANGES SINCE LAST ACTION
serge-sans-paille updated this revision to Diff 486049.
serge-sans-paille added a comment.
+ keep deprecated version, flagged appropriately
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140896/new/
https://reviews.llvm.org/D140896
Files:
bolt/tools/bat-dump/bat-dump.cpp
jpienaar added inline comments.
Comment at: llvm/include/llvm/ADT/ArrayRef.h:502
+ /// Deduction guide to construct an ArrayRef from a C array.
+ template ArrayRef(const T ()[N]) -> ArrayRef;
mehdi_amini wrote:
> Can we keep the makeArrayRef functions for
mehdi_amini added inline comments.
Herald added a subscriber: Michael137.
Comment at: llvm/include/llvm/ADT/ArrayRef.h:502
+ /// Deduction guide to construct an ArrayRef from a C array.
+ template ArrayRef(const T ()[N]) -> ArrayRef;
Can we keep the
serge-sans-paille created this revision.
Herald added subscribers: libc-commits, hanchung, kadircet, Moerafaat,
kmitropoulou, zero9178, Enna1, bzcheeseman, kosarev, mattd, gchakrabarti,
ThomasRaoux, pmatos, asb, ayermolo, awarzynski, arjunp, sdasgup3, asavonic,
carlosgalvezp, Groverkss,
