sylvestre.ledru added a comment.
thanks. reverting is fine :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141047/new/
https://reviews.llvm.org/D141047
___
cfe-commits mailing list
kadircet added inline comments.
Comment at: clang/cmake/modules/AddGRPC.cmake:7
generate_proto_sources(ProtoSource ${ProtoFile} ${PROTO_UNPARSED_ARGUMENTS})
+ set(LINKED_GRPC_LIBRARIES protobuf gpr grpc grpc++)
Hi @sylvestre.ledru this seem to have broken
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9f3081dc6fe8: build: with -DCLANGD_ENABLE_REMOTE=ON, search
for grpc++ dependencies too (authored by sylvestre.ledru).
Repository:
rG LLVM Github
serge-sans-paille accepted this revision.
serge-sans-paille added a comment.
This revision is now accepted and ready to land.
LGTM, assuming, you actually tested that locally.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141047/new/
sylvestre.ledru updated this revision to Diff 486546.
sylvestre.ledru added a comment.
add the missing {}
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141047/new/
https://reviews.llvm.org/D141047
Files:
clang/cmake/modules/AddGRPC.cmake
serge-sans-paille added inline comments.
Comment at: cmake/Modules/FindGRPC.cmake:85
if(NOT TARGET grpc++)
+find_library(GPR_LIBRARY gpr $GRPC_OPTS REQUIRED)
+add_library(gpr UNKNOWN IMPORTED GLOBAL)
Shouldn't this be `${GPRC_OPTS}`?
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: serge-sans-paille.
Herald added subscribers: bmahjour, kadircet, arphaman.
Herald added a project: All.
sylvestre.ledru requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald
