This revision was automatically updated to reflect the committed changes.
Closed by commit rGfd5e26270660: [ModuleUtils][KCFI] Set
patchable-function-prefix for synthesized functions (authored by samitolvanen).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
samitolvanen updated this revision to Diff 487536.
samitolvanen marked an inline comment as done.
samitolvanen added a comment.
Addressed feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141172/new/
https://reviews.llvm.org/D141172
Files:
samitolvanen added inline comments.
Comment at: llvm/test/Instrumentation/AddressSanitizer/kcfi-offset.ll:1
+;; Test that we set patchable-function-prefix for asan.module_ctor when
kcfi-offset is defined.
+
MaskRay wrote:
>
MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/lib/Transforms/Utils/ModuleUtils.cpp:169
+unsigned Offset = MD->getZExtValue();
+if (Offset)
+ F.addFnAttr("patchable-function-prefix",
samitolvanen created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
samitolvanen requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
When -fpatchable-function-entry is used to emit prefix