Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. In http://reviews.llvm.org/D14180#300193, @martell wrote: > @rnk you are correct. > mingw-w64 has been updated accordingly > > http://sourceforge.net/p/mingw-w64/mingw-w64/ci/61c374ded91a7de66f42f85a9f0cf9ee20/ > > So where do we go from here ? Let's disable the

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. In http://reviews.llvm.org/D14180#299183, @martell wrote: > I tried testing __has_builtin(_InterlockedCompareExchangeAdd) as it seem to > not exist even when -fms-extensions is passed > Is this a bug or it is intended ? Neither Clang nor MSDN have anything by that name.

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

On Tue, Dec 1, 2015 at 8:06 PM, Ismail Donmez wrote: > Hi, > > On Tue, Dec 1, 2015 at 7:45 PM, Reid Kleckner via cfe-commits > wrote: >> rnk added a comment. >> >> In http://reviews.llvm.org/D14180#299183, @martell wrote: >> >>> I tried testing

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

Hi, On Tue, Dec 1, 2015 at 7:45 PM, Reid Kleckner via cfe-commits wrote: > rnk added a comment. > > In http://reviews.llvm.org/D14180#299183, @martell wrote: > >> I tried testing __has_builtin(_InterlockedCompareExchangeAdd) as it seem to >> not exist even when

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. I tried testing __has_builtin(_InterlockedCompareExchangeAdd) as it seem to not exist even when -fms-extensions is passed Is this a bug or it is intended ? http://reviews.llvm.org/D14180 ___ cfe-commits mailing list

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. > ! In http://reviews.llvm.org/D14180#280193, @martell wrote: > > > You can then change the mingw headers to use > > `__has_builtin(_InterlockedCompareExchange)` to provide compatibility with > > either mode. > > > Yes I could do this but this still won't work with

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. > This is what I'm worried about. :) Can you elaborate on what would break? Essentially mingw-w64 has a few header defines for working around builtings such as __rtdsc and the interlocked functions and some other builtins As soon as one of these headers are included it

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. In http://reviews.llvm.org/D14180#279962, @martell wrote: > In http://reviews.llvm.org/D14180#279651, @rnk wrote: > > > Will Clang be able to compile the last few stable mingw-w64 releases with > > this change? I'd like that to keep working. > > > Clang has not been able to

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. In http://reviews.llvm.org/D14180#280184, @rnk wrote: > You're mostly interested in the non-builtin parts of -fms-extensions, like > declspec and UUID, right? Yes that would be one of the main reasons, gcc is very lacking in this department :) > You can then change

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. I'd like clang to work out of the box with mingw-w64 releases from at least the past year. You're mostly interested in the non-builtin parts of -fms-extensions, like declspec and UUID, right? One way we could do this is to enable -fms-extensions in mingw but then suppress

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. In http://reviews.llvm.org/D14180#279651, @rnk wrote: > Will Clang be able to compile the last few stable mingw-w64 releases with > this change? I'd like that to keep working. Clang has not been able to compile mingw-w64 crt for the last few releases. I have only

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. Will Clang be able to compile the last few stable mingw-w64 releases with this change? I'd like that to keep working. http://reviews.llvm.org/D14180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell created this revision. martell added a reviewer: rnk. martell added subscribers: cfe-commits, yaron.keren, compnerd. As of commit b8a164 mingw-w64 support clang with -fms-extensions. We can built the mingw-w64 crt with clang now also. As we are dropping support for mingw.org I think

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

compnerd requested changes to this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision now requires changes to proceed. Please add a unit test for this. http://reviews.llvm.org/D14180 ___ cfe-commits mailing list